From: Greg KH <greg@kroah.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb/host/ohci-hcd.c: fix sparse warnings
Date: Wed, 22 Apr 2009 12:23:16 -0700 [thread overview]
Message-ID: <20090422192316.GA19411@kroah.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090165EFC9@mi8nycmail19.Mi8.com>
On Wed, Apr 22, 2009 at 01:50:56PM -0400, H Hartley Sweeten wrote:
> On Wednesday, April 22, 2009 10:42 AM, Greg KH wrote:
> > On Wed, Apr 22, 2009 at 01:39:34PM -0400, H Hartley Sweeten wrote:
> >> On Tuesday, April 21, 2009 10:53 PM, Greg KH wrote:
> >>> On Wed, Apr 15, 2009 at 10:04:17PM -0400, H Hartley Sweeten wrote:
> >>> Fix sparse warnings in drivers/usb/host/ohci-hcd.c.
> >>>>
> >>>> warning: symbol 'temp' shadows an earlier one
> >>>>
> >>>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >>>
> >>> I'm not seeing this sparse warning either.
> >>>
> >>> And you didn't fix the two sparse warnings I am seeing in this file,
> >>> so I'm going to think this patch doesn't really do anything :(
> >>
> >> Following are the sparse warnings I am seeing when building for an
> >> EP93xx ARM platform:
> >
> > Ah, on ARM, sorry, I was building on x86.
> >
> > Care to respin this one, and your other one without the whitespace
> > changes and line-wraps and resend them?
>
> Not a problem. I will have to attach the patches to avoid the
> line-warps.
> It appears that the wrapping is occurring when my emails be bounced thru
> one of my ISP's servers. I'm still trying to resolve that.
>
> Question: How do you do a git diff and keep the whitespace changes out?
Don't do the whitespace changes in the first place :)
thanks,
greg k-h
next prev parent reply other threads:[~2009-04-22 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 2:04 [PATCH] usb/host/ohci-hcd.c: fix sparse warnings H Hartley Sweeten
2009-04-22 5:53 ` Greg KH
2009-04-22 17:39 ` H Hartley Sweeten
2009-04-22 17:42 ` Greg KH
2009-04-22 17:50 ` H Hartley Sweeten
2009-04-22 19:23 ` Greg KH [this message]
2009-04-22 20:18 ` H Hartley Sweeten
2009-04-22 20:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422192316.GA19411@kroah.com \
--to=greg@kroah.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox