* "PRINTK_DEBUG"?
@ 2009-04-19 19:24 Robert P. J. Day
2009-04-21 11:55 ` "PRINTK_DEBUG"? Stefan Richter
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2009-04-19 19:24 UTC (permalink / raw)
To: Linux Kernel Mailing List
lib/Kconfig.debug: select PRINTK_DEBUG
should that perhaps refer to "DYNAMIC_PRINTK_DEBUG"? since there is
no such thing as a PRINTK_DEBUG Kconfig variable.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: "PRINTK_DEBUG"?
2009-04-19 19:24 "PRINTK_DEBUG"? Robert P. J. Day
@ 2009-04-21 11:55 ` Stefan Richter
2009-04-22 19:49 ` "PRINTK_DEBUG"? Jason Baron
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Richter @ 2009-04-21 11:55 UTC (permalink / raw)
To: Robert P. J. Day, Jason Baron; +Cc: Linux Kernel Mailing List
Robert P. J. Day wrote:
> lib/Kconfig.debug: select PRINTK_DEBUG
>
> should that perhaps refer to "DYNAMIC_PRINTK_DEBUG"? since there is
> no such thing as a PRINTK_DEBUG Kconfig variable.
Looks like a rudiment from an earlier version of Jason's "driver core:
basic infrastructure for per-module dynamic debug messages",
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=346e15beb5343c2eb8216d820f2ed8f150822b08
Search an LKML archive for '+#ifdef CONFIG_PRINTK_DEBUG'.
Jason, should it be deleted or replaced by something?
--
Stefan Richter
-=====-==--= -=-- =-=-=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "PRINTK_DEBUG"?
2009-04-21 11:55 ` "PRINTK_DEBUG"? Stefan Richter
@ 2009-04-22 19:49 ` Jason Baron
0 siblings, 0 replies; 3+ messages in thread
From: Jason Baron @ 2009-04-22 19:49 UTC (permalink / raw)
To: Stefan Richter, greg; +Cc: Robert P. J. Day, Linux Kernel Mailing List
On Tue, Apr 21, 2009 at 01:55:53PM +0200, Stefan Richter wrote:
> Robert P. J. Day wrote:
> > lib/Kconfig.debug: select PRINTK_DEBUG
> >
> > should that perhaps refer to "DYNAMIC_PRINTK_DEBUG"? since there is
> > no such thing as a PRINTK_DEBUG Kconfig variable.
>
> Looks like a rudiment from an earlier version of Jason's "driver core:
> basic infrastructure for per-module dynamic debug messages",
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=346e15beb5343c2eb8216d820f2ed8f150822b08
> Search an LKML archive for '+#ifdef CONFIG_PRINTK_DEBUG'.
>
> Jason, should it be deleted or replaced by something?
We re-named 'DYNAMIC_PRINTK_DEBUG' to 'DYNAMIC_DEBUG' in 2.6.30....
'PRINTK_DEBUG' as pointed out never existed. So, it appears to be
extraneous, and should be removed. thanks for pointing it out.
Signed-off-by: Jason Baron <jbaron@redhat.com>
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c6e854f..dd457af 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -891,7 +891,6 @@ config DYNAMIC_DEBUG
default n
depends on PRINTK
depends on DEBUG_FS
- select PRINTK_DEBUG
help
Compiles debug level messages into the kernel, which would not
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-22 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-19 19:24 "PRINTK_DEBUG"? Robert P. J. Day
2009-04-21 11:55 ` "PRINTK_DEBUG"? Stefan Richter
2009-04-22 19:49 ` "PRINTK_DEBUG"? Jason Baron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox