From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, alex.williamson@hp.com,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: linux-next: upstream tree build warnings
Date: Thu, 23 Apr 2009 00:24:03 -0700 (PDT) [thread overview]
Message-ID: <20090423.002403.74400050.davem@davemloft.net> (raw)
In-Reply-To: <20090423163847.200f227e.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Apr 2009 16:38:47 +1000
> Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced these
> warnings:
>
> drivers/net/virtio_net.c: In function 'virnet_vlan_rx_add_vid':
> include/linux/scatterlist.h:57: warning: 'sg' is used uninitialized in this function
> drivers/net/virtio_net.c:746: note: 'sg' was declared here
> drivers/net/virtio_net.c: In function 'virnet_vlan_rx_kill_vid':
> include/linux/scatterlist.h:57: warning: 'sg' is used uninitialized in this function
> drivers/net/virtio_net.c:758: note: 'sg' was declared here
>
> in each case, sg is uninitialised when its address is passed to
> sg_set_buf() which passes it to gs_set_page() which passes it to
> sg_assign_page() which dereferences it (to use ->page_link).
I wonder if this is a side effect of changes that went in via Rusty's
tree? I don't remember touching this driver in a while.
next parent reply other threads:[~2009-04-23 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090423163847.200f227e.sfr@canb.auug.org.au>
2009-04-23 7:24 ` David Miller [this message]
2009-04-23 11:55 ` linux-next: upstream tree build warnings Stephen Rothwell
2009-04-23 12:51 ` Stephen Rothwell
2009-04-23 16:46 ` Alex Williamson
2009-04-26 12:23 ` Rusty Russell
2009-04-27 6:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423.002403.74400050.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.williamson@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox