public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: fmhess@users.sourceforge.net
Cc: Roel Kluin <roel.kluin@gmail.com>, Greg KH <gregkh@suse.de>,
	lkml <linux-kernel@vger.kernel.org>,
	Ian Abbott <abbotti@mev.co.uk>, David Schleef <ds@schleef.org>
Subject: Re: staging: comedi: non working tests on unsigned cmd->convert_arg
Date: Wed, 22 Apr 2009 19:08:24 -0700	[thread overview]
Message-ID: <20090423020824.GA6083@kroah.com> (raw)
In-Reply-To: <200904221411.13851.fmhess@speakeasy.net>

On Wed, Apr 22, 2009 at 02:11:10PM -0400, Frank Mori Hess wrote:
> On Wednesday 22 April 2009, Greg KH wrote:
> > On Tue, Apr 21, 2009 at 03:18:10PM +0200, Roel Kluin wrote:
> > > vi drivers/staging/comedi/comedi.h +342
> > >
> > > and note that cmd->convert_arg in s626_ai_cmdtest() is unsigned.
> > > Should there maybe be a test:
> > >
> > > if (cmd->convert_src == TRIG_EXT && cmd->convert_arg > MAX)
> > >
> > > (and what should MAX be then?)
> >
> > I don't know.  Let's ask the comedi developers :)
> >
> > Frank, what do you think about this?
> 
> 
> It looks like there already is such a test, right below the useless one the 
> patch removes.

Ok, thanks for checking.  Roel, care to resend these patches then?

thanks,

greg k-h

  parent reply	other threads:[~2009-04-23  2:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21 13:18 staging: comedi: non working tests on unsigned cmd->convert_arg Roel Kluin
2009-04-21 13:22 ` Roel Kluin
2009-04-22 16:50 ` Greg KH
2009-04-22 17:59   ` Ian Abbott
     [not found]   ` <200904221411.13851.fmhess@speakeasy.net>
2009-04-23  2:08     ` Greg KH [this message]
2009-04-23 10:23       ` Roel Kluin
2009-04-23 10:53         ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423020824.GA6083@kroah.com \
    --to=greg@kroah.com \
    --cc=abbotti@mev.co.uk \
    --cc=ds@schleef.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox