From: Paul Mundt <lethal@linux-sh.org>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Christoph Lameter <cl@linux.com>, Nick Piggin <npiggin@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"randy.dunlap@oracle.com" <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
"iwamatsu.nobuhiro@renesas.com" <iwamatsu.nobuhiro@renesas.com>
Subject: Re: linux-next ia64 build problems in slqb
Date: Thu, 23 Apr 2009 14:50:49 +0900 [thread overview]
Message-ID: <20090423055049.GA21733@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0904220953040.20610@melkki.cs.Helsinki.FI>
On Wed, Apr 22, 2009 at 10:02:06AM +0300, Pekka J Enberg wrote:
> On Tue, 21 Apr 2009, Luck, Tony wrote:
> > > One minor nit: the patch should define an empty static inline of
> > > claim_remote_free_list() for the !SMP case. I can fix it at my end
> > > before merging, though, if necessary.
> >
> > Agreed. It would be better to have an empty static inline than
> > adding the noisy #ifdef SMP around every call to
> > claim_remote_free_list() ... in fact some such #ifdef can be
> > removed.
> >
> > You could tag such a modified patch (attached) as:
> >
> > Acked-by: Tony Luck <tony.luck@intel.com>
>
> Thanks for the help! I went and merged the following patch and I hope I
> got all the patch attributions right. Paul, does this work for you as well?
>
Yup, works fine for me, thanks for taking care of this.
Acked-by: Paul Mundt <lethal@linux-sh.org>
prev parent reply other threads:[~2009-04-23 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 22:08 linux-next ia64 build problems in slqb Luck, Tony
2009-04-20 23:42 ` Randy Dunlap
2009-04-20 23:59 ` Luck, Tony
2009-04-21 5:51 ` Pekka Enberg
2009-04-21 6:29 ` Paul Mundt
2009-04-21 14:35 ` Christoph Lameter
2009-04-21 18:25 ` Pekka Enberg
2009-04-21 18:45 ` Luck, Tony
2009-04-21 19:07 ` Pekka Enberg
2009-04-21 22:31 ` Luck, Tony
2009-04-22 7:02 ` Pekka J Enberg
2009-04-23 5:50 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423055049.GA21733@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iwamatsu.nobuhiro@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=randy.dunlap@oracle.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).