Re: [PATCH 18/22] Use allocation flags as an index to the zone watermark

KOSAKI Motohiro
2009-04-24T06:41:33Z

> Considering that they are the same type for elements and arrays, I
> didn't think padding would ever be a problem.
>
> > However, all gcc version don't do that. I think. but perhaps I missed
> > some minor gcc release..
> >
> > So, I also like Dave's idea. but it only personal feeling.
> >
>
> The tide is against me on this one :).
>
> How about I roll a patch on top of this set that replaces the union by
> calling all sites? I figure that patch will go through a few revisions before
> people are happy with the final API. However, as the patch wouldn't change
> functionality, I'd like to see this series getting wider testing if possible. The
> replace-union-with-single-array patch can be easily folded in then when
> it settles.
>
> Sound like a plan?

Yeah, I agree testing is important than ugliness discussion :)