Re: [PATCH 09/22] Calculate the alloc_flags for allocation only once

Andrew Morton
2009-04-24T17:57:17Z

On Fri, 24 Apr 2009 11:47:17 +0100 Mel Gorman <mel@csn.ul.ie> wrote:

> Uninline gfp_to_alloc_flags() in the page allocator slow path

Well, there are <boggle> 37 inlines in page_alloc.c, so uninlining a
single function (and leaving its layout mucked up ;)) is a bit random.

Perhaps sometime you could take a look at "[patch] page allocator:
rationalise inlining"?

I'm kind of in two minds about it. Do we really know that all approved
versions of gcc will do the most desirable thing in all circumstances
on all architectures?