From: Jamie Lokier <jamie@shareable.org>
To: Tim Bird <tim.bird@am.sony.com>
Cc: "linux kernel" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Russell King" <rmk@arm.linux.org.uk>
Subject: Re: [PATCH] Add function graph tracer support for ARM (resend)
Date: Thu, 23 Apr 2009 20:17:08 +0100 [thread overview]
Message-ID: <20090423191708.GC13326@shareable.org> (raw)
In-Reply-To: <49F0B4FE.8070107@am.sony.com>
Tim Bird wrote:
> The use of "already_here" works around trace entry nesting
> (I believe due to instrumentation of either cpu_clock or
> raw_smp_processor_id). Advice on the best way to deal
> with this would be appreciated. (that is, whether
> to use the guard variable, or just un-instrument the
> offending routines).
I think it's better to keep functions instrumented where possible, if
checking for context isn't too expensive. Sometimes it's interesting
to see how many times they are called.
But it's not much use instrumenting those functions if activity on a
different CPU suppresses it. Is there no way to make "already_here"
task/CPU specific?
What do other architectures do? Consistency is good.
-- Jamie
prev parent reply other threads:[~2009-04-23 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 18:35 [PATCH] Add function graph tracer support for ARM (resend) Tim Bird
2009-04-23 19:17 ` Jamie Lokier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423191708.GC13326@shareable.org \
--to=jamie@shareable.org \
--cc=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rmk@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
--cc=tim.bird@am.sony.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox