public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/4] ptrace: remove PT_DTRACE from arch/m32r
@ 2009-04-23 19:32 Oleg Nesterov
  2009-04-24  3:29 ` Hirokazu Takata
  0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2009-04-23 19:32 UTC (permalink / raw)
  To: Andrew Morton, Roland McGrath
  Cc: Chris Zankel, David Howells, Geert Uytterhoeven, Greg Ungerer,
	Haavard Skinnemoen, Helge Deller, Hirokazu Takata, Jeff Dike,
	Kyle McMartin, Martin Schwidefsky, Mike Frysinger, Paul Mundt,
	Roman Zippel, Yoshinori Sato, linux-kernel

m32r: PTRACE_SINGLESTEP sets PT_DTRACE, it is never used except cleared
after do_execve().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>

 arch/m32r/kernel/process.c |    5 -----
 arch/m32r/kernel/ptrace.c  |    4 ----
 2 files changed, 9 deletions(-)

--- PTRACE/arch/m32r/kernel/process.c~DT_4_m32r	2009-04-06 00:03:35.000000000 +0200
+++ PTRACE/arch/m32r/kernel/process.c	2009-04-22 22:01:44.000000000 +0200
@@ -302,11 +302,6 @@ asmlinkage int sys_execve(char __user *u
 		goto out;
 
 	error = do_execve(filename, uargv, uenvp, &regs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 	return error;
--- PTRACE/arch/m32r/kernel/ptrace.c~DT_4_m32r	2009-04-06 00:03:35.000000000 +0200
+++ PTRACE/arch/m32r/kernel/ptrace.c	2009-04-22 22:00:13.000000000 +0200
@@ -676,10 +676,6 @@ arch_ptrace(struct task_struct *child, l
 		if (!valid_signal(data))
 			break;
 		clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
-		if ((child->ptrace & PT_DTRACE) == 0) {
-			/* Spurious delayed TF traps may occur */
-			child->ptrace |= PT_DTRACE;
-		}
 
 		/* Compute next pc.  */
 		pc = get_stack_long(child, PT_BPC);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 4/4] ptrace: remove PT_DTRACE from arch/m32r
  2009-04-23 19:32 [PATCH 4/4] ptrace: remove PT_DTRACE from arch/m32r Oleg Nesterov
@ 2009-04-24  3:29 ` Hirokazu Takata
  0 siblings, 0 replies; 2+ messages in thread
From: Hirokazu Takata @ 2009-04-24  3:29 UTC (permalink / raw)
  To: Oleg Nesterov
  Cc: Andrew Morton, Roland McGrath, Chris Zankel, David Howells,
	Geert Uytterhoeven, Greg Ungerer, Haavard Skinnemoen,
	Helge Deller, Hirokazu Takata, Jeff Dike, Kyle McMartin,
	Martin Schwidefsky, Mike Frysinger, Paul Mundt, Roman Zippel,
	Yoshinori Sato, linux-kernel

From: Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH 4/4] ptrace: remove PT_DTRACE from arch/m32r
Date: Thu, 23 Apr 2009 21:32:15 +0200
> m32r: PTRACE_SINGLESTEP sets PT_DTRACE, it is never used except cleared
> after do_execve().
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Acked-by: Hirokazu Takata <takata@linux-m32r.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-24  3:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23 19:32 [PATCH 4/4] ptrace: remove PT_DTRACE from arch/m32r Oleg Nesterov
2009-04-24  3:29 ` Hirokazu Takata

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox