From: Mark Brown <broonie@sirena.org.uk>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org,
philipp.zabel@gmail.com
Subject: Re: [PATCH v2] Maxim 1586 regulator driver
Date: Thu, 23 Apr 2009 21:02:33 +0100 [thread overview]
Message-ID: <20090423200232.GD6642@sirena.org.uk> (raw)
In-Reply-To: <1240510243-28969-1-git-send-email-robert.jarzmik@free.fr>
On Thu, Apr 23, 2009 at 08:10:43PM +0200, Robert Jarzmik wrote:
> +/*
> + * max1586.c -- Voltage and current regulation for the Maxim 1586
> + *
> + * Copyright (C) 2008 Robert Jarzmik
You're living in the past here!
> +/*
> + * V6 voltage
> + * On I2C bus, sending a "x" byte to the max1586 means :
> + * set V6 to either 0V, 1.8V, 2.5V, 3V depending on (x & 0x3)
> + * As regulator framework doesn't accept voltages to be 0V, we use 1uV.
> + */
Having seen the regulation constraints you're using on your board I'm
thinking even more that it'd be better to implement enable and disable
operations for the driver. On the other hand, the driver is useful now
and my other comments are all very much nitpicks so from my point of
view:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> + dev_dbg(&client->dev, "changing voltage v6 to %dmv\n",
> + max1586_v6_calc_voltage(selector) / 1000);
mv should be mV.
next prev parent reply other threads:[~2009-04-23 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 18:10 [PATCH v2] Maxim 1586 regulator driver Robert Jarzmik
2009-04-23 20:02 ` Mark Brown [this message]
2009-04-27 12:40 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423200232.GD6642@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=philipp.zabel@gmail.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox