Re: [patch 00/11] Hardware Breakpoint interfaces

Ingo Molnar
2009-03-10T13:52:15Z

There's also a few checkpatch warnings that need to be
addressed:

ERROR: do not use assignment in if condition
#1084: FILE: arch/x86/kernel/ptrace.c:581:
+ else if ((thbi = alloc_thread_hw_breakpoint(tsk)) ==
NULL)

WARNING: suspect code indent for conditional statements (16, 16)
#2836: FILE: kernel/trace/trace_ksym.c:324:
+ if (strncmp(entry->ksym_hbkpt->info.name,
KSYM_SELFTEST_ENTRY,
[...]
+ kfree(entry->ksym_hbkpt->info.name);

Ingo