From: Jens Axboe <jens.axboe@oracle.com>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-2.6-block/for-linus] Fix discard requests accounting in the diskstats
Date: Fri, 24 Apr 2009 08:15:18 +0200 [thread overview]
Message-ID: <20090424061518.GY4593@kernel.dk> (raw)
In-Reply-To: <200904241118.30919.knikanth@suse.de>
On Fri, Apr 24 2009, Nikanth Karthikesan wrote:
> When 2 discard requests are merged, the stats gets updated, but we do not
> update statistics normally when a discard request is issued or completed. For
> example the in_flight counter would be decremented when 2 discard requests are
> merged, but it was not at all incremented when they were issued, and in_flight
> counter will not be decremented, when they are completed as well.
>
> This patch fixes this by adding discard requests to the statistics.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
OK, so that's not quite what I had in mind. If we first do this as a
preparatory patch:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=42fd769da4edadad83a779867ff1910ec35c6de7
then the discard fix becomes this one-liner:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=999ae79ae7f853bb9e60e95753ebf8d1628e632a
--
Jens Axboe
next prev parent reply other threads:[~2009-04-24 6:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200904232013.n3NKD4PP017241@imap1.linux-foundation.org>
[not found] ` <20090423140448.c2d34fb8.akpm@linux-foundation.org>
[not found] ` <20090424051612.GT4593@kernel.dk>
2009-04-24 5:48 ` [PATCH linux-2.6-block/for-linus] Fix discard requests accounting in the diskstats Nikanth Karthikesan
2009-04-24 6:15 ` Jens Axboe [this message]
2009-04-24 7:38 ` Nikanth Karthikesan
2009-04-24 7:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090424061518.GY4593@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox