Re: [PATCH 0/5 -tip] umount_begin BKL pushdown

Ingo Molnar
2009-04-23T21:33:20Z

* Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Thu, Apr 23, 2009 at 09:12:00PM +0200, Alessio Igor Bogani wrote:
> > Push the BKL acquisition from vfs to every specific filesystems
> > with hope that it can be eliminated in a second moment.
> >
> > The first 4 patches add BKL lock into umount_begin() functions
> > (for the filesystems that have this handler). The last one
> > remove lock_kernel()/unlock_kernel() from fs/namespace.c (the
> > only point that invoke umount_begin() funtcions).
>
> I'd rather collapse all these patches together; no point doing
> that per-fs (for all 4 of them). And CIFS side is bogus.
>
> Another thing: -tip is no place for that. I can put that into VFS
> tree, provided that comments above are dealt with.

When that happens, could you please put it into a separate,
append-only branch i could pull (after some initial test-time) into
tip:kill-the-BKL?

Thanks,

Ingo