Re: [PATCH linux-2.6-block/for-linus] Fix discard requests accounting in the diskstats

[Nikanth Karthikesan <knikanth@suse.de>]

On Friday 24 April 2009 11:45:18 Jens Axboe wrote:
> On Fri, Apr 24 2009, Nikanth Karthikesan wrote:
> > When 2 discard requests are merged, the stats gets updated, but we do not
> > update statistics normally when a discard request is issued or completed.
> > For example the in_flight counter would be decremented when 2 discard
> > requests are merged, but it was not at all incremented when they were
> > issued, and in_flight counter will not be decremented, when they are
> > completed as well.
> >
> > This patch fixes this by adding discard requests to the statistics.
> >
> > Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
>
> OK, so that's not quite what I had in mind. If we first do this as a
> preparatory patch:
>
> http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=42fd769da4edadad83a7
>79867ff1910ec35c6de7
>

Oh! I thought this cleanup along with the 
block-turn-some-buggy-macros-into-c-functions.patch from Andrew could be done 
on top of my original fix. But didn't, as you said, you would do it. Anyway, 
Thanks.

> then the discard fix becomes this one-liner:
>
> http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=999ae79ae7f853bb9e60
>e95753ebf8d1628e632a

Thanks
Nikanth