From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <rth@twiddle.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: binfmt_aout fix
Date: Fri, 24 Apr 2009 21:19:52 +0100 [thread overview]
Message-ID: <20090424201952.GQ8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090424154602.GA368@jurassic.park.msu.ru>
On Fri, Apr 24, 2009 at 07:46:02PM +0400, Ivan Kokshaysky wrote:
> On Fri, Apr 24, 2009 at 04:05:49PM +0100, Al Viro wrote:
> > On Fri, Apr 24, 2009 at 06:47:38PM +0400, Ivan Kokshaysky wrote:
> > > Fixed by changing the registration order of the default
> > > binfmt handlers using list_add_tail() and introducing insert_binfmt()
> > > function which places new handler on the top of the binfmt list.
> > > This might be generally useful for installing arch-specific frontends
> > > for default handlers or just for overriding them.
> >
> > Hmm... How about always doing list_add_tail() instead?
>
> That would fix the module case, but gets broken when binfmt_aout
> in built-in, because the generic handlers are registered pretty
> early (core_initcall) and alpha binfmt_loader is an arch_initcall.
OK, probably the easiest way to deal with that.
ACK
next prev parent reply other threads:[~2009-04-24 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 14:47 [PATCH] alpha: binfmt_aout fix Ivan Kokshaysky
2009-04-24 15:05 ` Al Viro
2009-04-24 15:46 ` Ivan Kokshaysky
2009-04-24 20:19 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-17 10:49 Ivan Kokshaysky
2009-02-17 11:08 ` Christoph Hellwig
2009-02-17 11:40 ` Ivan Kokshaysky
2009-02-18 23:52 ` Andrew Morton
2009-02-19 9:40 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090424201952.GQ8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox