From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: [PATCH 1/5] tracing/lockdep: convert lockdep to use TRACE_EVENT macro
Date: Sat, 25 Apr 2009 00:20:31 -0400 [thread overview]
Message-ID: <20090425042629.332398282@goodmis.org> (raw)
In-Reply-To: 20090425042030.431477667@goodmis.org
[-- Attachment #1: 0001-tracing-lockdep-convert-lockdep-to-use-TRACE_EVENT.patch --]
[-- Type: text/plain, Size: 2212 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The TRACE_FORMAT will soon be deprecated. This patch converts it to
the TRACE_EVENT macro.
Note, this change should also speed up the tracing.
[ Impact: remove a user of deprecated TRACE_FORMAT ]
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/events/lockdep.h | 56 ++++++++++++++++++++++++++++++++-------
1 files changed, 46 insertions(+), 10 deletions(-)
diff --git a/include/trace/events/lockdep.h b/include/trace/events/lockdep.h
index 3ca315c..0e956c9 100644
--- a/include/trace/events/lockdep.h
+++ b/include/trace/events/lockdep.h
@@ -9,28 +9,64 @@
#ifdef CONFIG_LOCKDEP
-TRACE_FORMAT(lock_acquire,
+TRACE_EVENT(lock_acquire,
+
TP_PROTO(struct lockdep_map *lock, unsigned int subclass,
int trylock, int read, int check,
struct lockdep_map *next_lock, unsigned long ip),
+
TP_ARGS(lock, subclass, trylock, read, check, next_lock, ip),
- TP_FMT("%s%s%s", trylock ? "try " : "",
- read ? "read " : "", lock->name)
- );
-TRACE_FORMAT(lock_release,
+ TP_STRUCT__entry(
+ __field(unsigned int, flags)
+ __string(name, lock->name)
+ ),
+
+ TP_fast_assign(
+ __entry->flags = (trylock ? 1 : 0) | (read ? 2 : 0);
+ __assign_str(name, lock->name);
+ ),
+
+ TP_printk("%s%s%s", (__entry->flags & 1) ? "try " : "",
+ (__entry->flags & 2) ? "read " : "",
+ __get_str(name))
+);
+
+TRACE_EVENT(lock_release,
+
TP_PROTO(struct lockdep_map *lock, int nested, unsigned long ip),
+
TP_ARGS(lock, nested, ip),
- TP_FMT("%s", lock->name)
- );
+
+ TP_STRUCT__entry(
+ __string(name, lock->name)
+ ),
+
+ TP_fast_assign(
+ __assign_str(name, lock->name);
+ ),
+
+ TP_printk("%s", __get_str(name))
+);
#ifdef CONFIG_LOCK_STAT
-TRACE_FORMAT(lock_contended,
+TRACE_EVENT(lock_contended,
+
TP_PROTO(struct lockdep_map *lock, unsigned long ip),
+
TP_ARGS(lock, ip),
- TP_FMT("%s", lock->name)
- );
+
+ TP_STRUCT__entry(
+ __string(name, lock->name)
+ ),
+
+ TP_fast_assign(
+ __assign_str(name, lock->name);
+ ),
+
+ TP_printk("%s", __get_str(name))
+);
TRACE_EVENT(lock_acquired,
TP_PROTO(struct lockdep_map *lock, unsigned long ip, s64 waittime),
--
1.6.2.1
--
next prev parent reply other threads:[~2009-04-25 4:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 4:20 [PATCH 0/5] [GIT PULL] tracing/events: remove TRACE_FORMAT and handle overflow ids Steven Rostedt
2009-04-25 4:20 ` Steven Rostedt [this message]
2009-04-25 4:20 ` [PATCH 2/5] tracing/irq: convert irq traces to use TRACE_EVENT macro Steven Rostedt
2009-04-25 4:20 ` [PATCH 3/5] tracing: remove deprecated TRACE_FORMAT Steven Rostedt
2009-04-25 4:20 ` [PATCH 4/5] tracing/events: reuse trace event ids after overflow Steven Rostedt
2009-04-25 4:20 ` [PATCH 5/5] tracing/events: make modules have their own file_operations structure Steven Rostedt
2009-04-25 17:26 ` Greg KH
2009-04-26 11:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090425042629.332398282@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox