From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>, Jason Baron <jbaron@redhat.com>
Subject: [PATCH 2/5] tracing/irq: convert irq traces to use TRACE_EVENT macro
Date: Sat, 25 Apr 2009 00:20:32 -0400 [thread overview]
Message-ID: <20090425042630.348109173@goodmis.org> (raw)
In-Reply-To: 20090425042030.431477667@goodmis.org
[-- Attachment #1: 0002-tracing-irq-convert-irq-traces-to-use-TRACE_EVENT-m.patch --]
[-- Type: text/plain, Size: 2361 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The TRACE_FORMAT will soon be deprecated. This patch converts it to
the TRACE_EVENT macro.
Note, this change should also speed up the tracing.
[ Impact: remove a user of deprecated TRACE_FORMAT ]
Cc: Jason Baron <jbaron@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/events/irq.h | 57 +++++++++++++++++++++++++++++++++++++-------
1 files changed, 48 insertions(+), 9 deletions(-)
diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
index 75e3468..7686864 100644
--- a/include/trace/events/irq.h
+++ b/include/trace/events/irq.h
@@ -10,11 +10,24 @@
/*
* Tracepoint for entry of interrupt handler:
*/
-TRACE_FORMAT(irq_handler_entry,
+TRACE_EVENT(irq_handler_entry,
+
TP_PROTO(int irq, struct irqaction *action),
+
TP_ARGS(irq, action),
- TP_FMT("irq=%d handler=%s", irq, action->name)
- );
+
+ TP_STRUCT__entry(
+ __field( int, irq )
+ __string( name, action->name )
+ ),
+
+ TP_fast_assign(
+ __entry->irq = irq;
+ __assign_str(name, action->name);
+ ),
+
+ TP_printk("irq=%d handler=%s", __entry->irq, __get_str(name))
+);
/*
* Tracepoint for return of an interrupt handler:
@@ -39,17 +52,43 @@ TRACE_EVENT(irq_handler_exit,
__entry->irq, __entry->ret ? "handled" : "unhandled")
);
-TRACE_FORMAT(softirq_entry,
+TRACE_EVENT(softirq_entry,
+
TP_PROTO(struct softirq_action *h, struct softirq_action *vec),
+
TP_ARGS(h, vec),
- TP_FMT("softirq=%d action=%s", (int)(h - vec), softirq_to_name[h-vec])
- );
-TRACE_FORMAT(softirq_exit,
+ TP_STRUCT__entry(
+ __field( int, vec )
+ __string( name, softirq_to_name[h-vec] )
+ ),
+
+ TP_fast_assign(
+ __entry->vec = (int)(h - vec);
+ __assign_str(name, softirq_to_name[h-vec]);
+ ),
+
+ TP_printk("softirq=%d action=%s", __entry->vec, __get_str(name))
+);
+
+TRACE_EVENT(softirq_exit,
+
TP_PROTO(struct softirq_action *h, struct softirq_action *vec),
+
TP_ARGS(h, vec),
- TP_FMT("softirq=%d action=%s", (int)(h - vec), softirq_to_name[h-vec])
- );
+
+ TP_STRUCT__entry(
+ __field( int, vec )
+ __string( name, softirq_to_name[h-vec] )
+ ),
+
+ TP_fast_assign(
+ __entry->vec = (int)(h - vec);
+ __assign_str(name, softirq_to_name[h-vec]);
+ ),
+
+ TP_printk("softirq=%d action=%s", __entry->vec, __get_str(name))
+);
#endif /* _TRACE_IRQ_H */
--
1.6.2.1
--
next prev parent reply other threads:[~2009-04-25 4:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 4:20 [PATCH 0/5] [GIT PULL] tracing/events: remove TRACE_FORMAT and handle overflow ids Steven Rostedt
2009-04-25 4:20 ` [PATCH 1/5] tracing/lockdep: convert lockdep to use TRACE_EVENT macro Steven Rostedt
2009-04-25 4:20 ` Steven Rostedt [this message]
2009-04-25 4:20 ` [PATCH 3/5] tracing: remove deprecated TRACE_FORMAT Steven Rostedt
2009-04-25 4:20 ` [PATCH 4/5] tracing/events: reuse trace event ids after overflow Steven Rostedt
2009-04-25 4:20 ` [PATCH 5/5] tracing/events: make modules have their own file_operations structure Steven Rostedt
2009-04-25 17:26 ` Greg KH
2009-04-26 11:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090425042630.348109173@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox