public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, mark.langsdorf@amd.com,
	arekm@maven.pl, "H. Peter Anvin" <hpa@zytor.com>,
	Andi Kleen <andi@firstfloor.org>, Avi Kivity <avi@qumranet.com>
Subject: Re: [patch 2/2] x86 amd fix cmpxchg read acquire barrier
Date: Sat, 25 Apr 2009 10:19:14 +0200	[thread overview]
Message-ID: <20090425081914.GD2428@ucw.cz> (raw)
In-Reply-To: <20090422202453.829846363@polymtl.ca>

On Wed 2009-04-22 16:18:54, Mathieu Desnoyers wrote:
> http://google-perftools.googlecode.com/svn-history/r48/trunk/src/base/atomicops-internals-x86.cc
> 
> says
> 
> "  // Opteron Rev E has a bug in which on very rare occasions a locked
>   // instruction doesn't act as a read-acquire barrier if followed by a
>   // non-locked read-modify-write instruction.  Rev F has this bug in 
>   // pre-release versions, but not in versions released to customers,
>   // so we test only for Rev E, which is family 15, model 32..63 inclusive.

Could we be more careful  here and catch the F pre-release versions,
too? Stepping should help there...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2009-04-25  8:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 20:18 [patch 0/2] Fixing AMD cmpxchg "missing lfence" mess Mathieu Desnoyers
2009-04-22 20:18 ` [patch 1/2] x86: cleanup alternative.h Mathieu Desnoyers
2009-04-28 13:05   ` [GIT PULL] " Mathieu Desnoyers
2009-04-28 14:58     ` Ingo Molnar
2009-04-28 15:13       ` [GIT PULL] x86: cleanup alternative.h (v2) Mathieu Desnoyers
2009-04-29  6:17         ` [tip:x86/asm] x86: clean up alternative.h tip-bot for Mathieu Desnoyers
2009-04-29  6:22           ` Mathieu Desnoyers
2009-04-28 17:40       ` [GIT PULL] x86: cleanup alternative.h H. Peter Anvin
2009-04-28 18:11         ` Mathieu Desnoyers
2009-04-28 18:13         ` [GIT PULL] x86: cleanup alternative.h (v3) Mathieu Desnoyers
2009-04-22 20:18 ` [patch 2/2] x86 amd fix cmpxchg read acquire barrier Mathieu Desnoyers
2009-04-22 20:59   ` Alan Cox
2009-04-22 22:47     ` Mathieu Desnoyers
2009-04-22 22:53       ` Alan Cox
2009-04-22 23:26         ` Mathieu Desnoyers
2009-04-23  8:06   ` Ingo Molnar
2009-04-23 13:19     ` Mathieu Desnoyers
2009-04-23 13:41       ` Arkadiusz Miskiewicz
2009-04-23 22:17         ` Mathieu Desnoyers
2009-04-25  8:19   ` Pavel Machek [this message]
2009-05-02 15:55     ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090425081914.GD2428@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arekm@maven.pl \
    --cc=avi@qumranet.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox