From: Greg KH <gregkh@suse.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: staging indentation & braces disagreement list
Date: Sat, 25 Apr 2009 10:48:26 -0700 [thread overview]
Message-ID: <20090425174826.GA26972@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0904251221060.22716@wrl-59.cs.helsinki.fi>
On Sat, Apr 25, 2009 at 12:28:06PM +0300, Ilpo Järvinen wrote:
> Hi,
>
> Below is a list from my braces vs indentation pipeline against
> staging (mainline 0c8454f56623)... Plenty of add-bracing/reindentation
> required but I'm busy elsewhere so I leave it up to somebody who wants
> to eyeball the code to see which of the alternatives is the
> right one. Please disregard the line numbers, they don't match
> with the source because the source was trimmed beforehand.
I wouldn't worry about the majority of these, they are getting replaced
with "real" wireless drivers soon :)
> drivers/staging/frontier/tranzport.c
> 183
> if (dev->offline == 2 && dev->interrupt_in_buffer[1] == 0xff)
> goto resubmit;
> if (dev->offline == 1 && dev->interrupt_in_buffer[1] == 0xff) {
> dev->offline = 2;
this is probably a bug :(
thanks,
greg k-h
prev parent reply other threads:[~2009-04-25 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 9:28 staging indentation & braces disagreement list Ilpo Järvinen
2009-04-25 17:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090425174826.GA26972@suse.de \
--to=gregkh@suse.de \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox