From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Rapoport <mike@compulab.co.il>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: add userspace-consumer driver
Date: Sun, 26 Apr 2009 13:00:37 +0100 [thread overview]
Message-ID: <20090426120036.GA10900@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <49F449B8.2010707@compulab.co.il>
On Sun, Apr 26, 2009 at 02:47:04PM +0300, Mike Rapoport wrote:
> Mark Brown wrote:
> > Why are you using a regulator_consumer_supply here? All that's being
> > used here is the name and I can't see why you'd want the device.
> For upwards compatibility :)
> Well, seriously, I think using 'struct regulator_consumer_supply *supplies'
> rather than 'char *supplies' makes the platform code that registers the
> userspace-consumer device clearer.
On the other hand it merges the consumer and machine APIs, which we
really want to keep separate, and I can't see having the struct device
in there doing anything except confuse people. If you're going to pick
an existing structure to use I'd be more inclined to use the bulk
consumer structure (which the driver needs to allocate anyway).
next prev parent reply other threads:[~2009-04-26 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 9:17 [PATCH 0/2] regulator: add userspace-consumer driver Mike Rapoport
2009-04-26 9:17 ` [PATCH 1/2] regulator: move regulator_consumer_supply from machine.h to consumer.h Mike Rapoport
2009-04-26 9:17 ` [PATCH 2/2] regulator: add userspace-consumer driver Mike Rapoport
2009-04-26 10:02 ` Mark Brown
2009-04-26 11:47 ` Mike Rapoport
2009-04-26 12:00 ` Mark Brown [this message]
2009-04-26 13:05 ` Mike Rapoport
2009-04-26 13:49 ` [PATCH] " Mike Rapoport
2009-04-27 11:43 ` Mark Brown
2009-04-27 12:30 ` Liam Girdwood
2009-04-27 12:29 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090426120036.GA10900@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox