From: Ingo Molnar <mingo@elte.hu>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount()
Date: Sun, 26 Apr 2009 18:39:24 +0200 [thread overview]
Message-ID: <20090426163924.GD6236@elte.hu> (raw)
In-Reply-To: <1240492586-6654-1-git-send-email-abogani@texware.it>
* Alessio Igor Bogani <abogani@texware.it> wrote:
> Fix ext3_remount()'s "schedule() drops the BKL automatically" assumption,
> when ext3_mark_recovery_complete(), which can sleep, does not do that it can
> lock up.
>
> Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
> ---
> fs/ext3/super.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index dc905f9..3fa457a 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2561,9 +2561,11 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
> * We have to unlock super so that we can wait for
> * transactions.
> */
> + unlock_kernel();
> unlock_super(sb);
> ext3_mark_recovery_complete(sb, es);
> lock_super(sb);
> + lock_kernel();
Shouldnt this be a conditional-unlock, so that if the remount moves
away from under the BKL we dont break in this place?
Ingo
next prev parent reply other threads:[~2009-04-26 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:16 [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount() Alessio Igor Bogani
2009-04-26 16:39 ` Ingo Molnar [this message]
2009-04-27 20:21 ` Alessio Igor Bogani
2009-04-27 20:22 ` [PATCH -tip:kill-the-BKL] " Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090426163924.GD6236@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=abogani@texware.it \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox