From: Evgeniy Polyakov <zbr@ioremap.net>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging - pohmelfs: Storage class should be before const qualifier
Date: Sun, 26 Apr 2009 22:01:35 +0400 [thread overview]
Message-ID: <20090426180135.GA13576@ioremap.net> (raw)
In-Reply-To: <1240751169-10167-1-git-send-email-tklauser@distanz.ch>
On Sun, Apr 26, 2009 at 03:06:09PM +0200, Tobias Klauser (tklauser@distanz.ch) wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Looks good, thank you.
Greg, please put it into the queue.
> ---
> drivers/staging/pohmelfs/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
> index b2eaf90..779445e 100644
> --- a/drivers/staging/pohmelfs/inode.c
> +++ b/drivers/staging/pohmelfs/inode.c
> @@ -943,7 +943,7 @@ err_out_unlock:
> return ret;
> }
>
> -const static struct file_operations pohmelfs_file_ops = {
> +static const struct file_operations pohmelfs_file_ops = {
> .open = generic_file_open,
> .fsync = pohmelfs_fsync,
>
> --
> 1.6.2.4
--
Evgeniy Polyakov
prev parent reply other threads:[~2009-04-26 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 13:06 [PATCH] staging - pohmelfs: Storage class should be before const qualifier Tobias Klauser
2009-04-26 18:01 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090426180135.GA13576@ioremap.net \
--to=zbr@ioremap.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox