public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE
@ 2009-04-27  9:33 Adrian Bunk
  2009-04-27 15:28 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2009-04-27  9:33 UTC (permalink / raw)
  To: Alan Stern, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel, Andrew Morton

This patch adds the missing MODULE_LICENSE("GPL").

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
index 468bde7..d62ea8f 100644
--- a/drivers/usb/storage/usual-tables.c
+++ b/drivers/usb/storage/usual-tables.c
@@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
+
+MODULE_LICENSE("GPL");


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE
  2009-04-27  9:33 [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE Adrian Bunk
@ 2009-04-27 15:28 ` Greg KH
  2009-04-27 16:37   ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2009-04-27 15:28 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, linux-kernel,
	Andrew Morton

On Mon, Apr 27, 2009 at 12:33:01PM +0300, Adrian Bunk wrote:
> This patch adds the missing MODULE_LICENSE("GPL").
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
> diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> index 468bde7..d62ea8f 100644
> --- a/drivers/usb/storage/usual-tables.c
> +++ b/drivers/usb/storage/usual-tables.c
> @@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
> +
> +MODULE_LICENSE("GPL");

Why is this needed?  This .c file gets built into either the libusual
module, or the usb-storage module, both of which have module licenses,
right?

confused,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE
  2009-04-27 15:28 ` Greg KH
@ 2009-04-27 16:37   ` Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2009-04-27 16:37 UTC (permalink / raw)
  To: Greg KH
  Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, linux-kernel,
	Andrew Morton

On Mon, Apr 27, 2009 at 08:28:19AM -0700, Greg KH wrote:
> On Mon, Apr 27, 2009 at 12:33:01PM +0300, Adrian Bunk wrote:
> > This patch adds the missing MODULE_LICENSE("GPL").
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > 
> > ---
> > 
> > diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> > index 468bde7..d62ea8f 100644
> > --- a/drivers/usb/storage/usual-tables.c
> > +++ b/drivers/usb/storage/usual-tables.c
> > @@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
> >  	return 0;
> >  }
> >  EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
> > +
> > +MODULE_LICENSE("GPL");
> 
> Why is this needed?  This .c file gets built into either the libusual
> module, or the usb-storage module, both of which have module licenses,
> right?

My fault, I ran into it some time ago, and missed that the actual 
problem was fixed by commit dfc15e8955338fedf5c5d15622c4042c1e4ee332

> confused,
> 
> greg k-h

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-04-27 16:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-27  9:33 [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE Adrian Bunk
2009-04-27 15:28 ` Greg KH
2009-04-27 16:37   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox