From: Greg KH <greg@kroah.com>
To: David Brownell <david-b@pacbell.net>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.30-rc3] platform_bus: remove "which platform_data?" confusion
Date: Mon, 27 Apr 2009 22:07:42 -0700 [thread overview]
Message-ID: <20090428050742.GB17432@kroah.com> (raw)
In-Reply-To: <200904271943.40588.david-b@pacbell.net>
On Mon, Apr 27, 2009 at 07:43:40PM -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Recent patches have caused platform_device_add_pdata() users
> to trigger confused "use which platform_data?" error messages
> from the kernel. ("The _only_ one you were given, dummy!" is
> the correct answer.)
>
> This patch fixes those messages so they only appear if there's
> reason to be confused. (The call should probably fail too...)
>
> Those patches seem to support what I think is a misguided
> notion: that somehow device.platform_data might move into
> the platform_device. The problem with that idea is that it's
> a general purpose hook, and is used by other busses to provide
> board-specific configuration data ... not just for platform_bus.
It is? What other busses do this? And why, can't they use their own
bus private data pointers?
thanks,
greg k-h
next prev parent reply other threads:[~2009-04-28 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 2:43 [patch 2.6.30-rc3] platform_bus: remove "which platform_data?" confusion David Brownell
2009-04-28 5:07 ` Greg KH [this message]
2009-04-28 9:28 ` David Brownell
2009-04-29 3:24 ` Greg KH
2009-04-29 5:01 ` David Brownell
2009-04-29 4:08 ` Greg KH
2009-04-29 12:08 ` Ming Lei
2009-04-29 18:16 ` Greg KH
2009-04-29 23:53 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428050742.GB17432@kroah.com \
--to=greg@kroah.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox