public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Kukkonen <mika.kukkonen@nokia.com>
To: lrg@slimlogic.co.uk
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Remove extra semicolon from if() in drivers/regulator/core.c
Date: Tue, 28 Apr 2009 10:17:51 +0300	[thread overview]
Message-ID: <20090428071751.GA25645@nokia.com> (raw)

In function drms_uA_update() in file drivers/regulator/core.c there is a tailing semicolon
in the end of if() condition which causes the function in question to return unconditionally.
Remove it to enable rest of the code in the function.

Signed-off-By: Mika Kukkonen <mika.kukkonen@nokia.com>

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 01f7702..47fc6e6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -540,8 +540,8 @@ static void drms_uA_update(struct regulator_dev *rdev)
 
 	err = regulator_check_drms(rdev);
 	if (err < 0 || !rdev->desc->ops->get_optimum_mode ||
-	    !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode);
-	return;
+	    !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode)
+		return;
 
 	/* get output voltage */
 	output_uV = rdev->desc->ops->get_voltage(rdev);


             reply	other threads:[~2009-04-28  7:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28  7:17 Mika Kukkonen [this message]
2009-04-28 13:51 ` [PATCH] Remove extra semicolon from if() in drivers/regulator/core.c Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090428071751.GA25645@nokia.com \
    --to=mika.kukkonen@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox