* [PATCH] Remove extra semicolon from if() in drivers/regulator/core.c
@ 2009-04-28 7:17 Mika Kukkonen
2009-04-28 13:51 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mika Kukkonen @ 2009-04-28 7:17 UTC (permalink / raw)
To: lrg; +Cc: linux-kernel
In function drms_uA_update() in file drivers/regulator/core.c there is a tailing semicolon
in the end of if() condition which causes the function in question to return unconditionally.
Remove it to enable rest of the code in the function.
Signed-off-By: Mika Kukkonen <mika.kukkonen@nokia.com>
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 01f7702..47fc6e6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -540,8 +540,8 @@ static void drms_uA_update(struct regulator_dev *rdev)
err = regulator_check_drms(rdev);
if (err < 0 || !rdev->desc->ops->get_optimum_mode ||
- !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode);
- return;
+ !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode)
+ return;
/* get output voltage */
output_uV = rdev->desc->ops->get_voltage(rdev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove extra semicolon from if() in drivers/regulator/core.c
2009-04-28 7:17 [PATCH] Remove extra semicolon from if() in drivers/regulator/core.c Mika Kukkonen
@ 2009-04-28 13:51 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2009-04-28 13:51 UTC (permalink / raw)
To: mika.kukkonen; +Cc: linux-kernel
On Tue, 2009-04-28 at 10:17 +0300, Mika Kukkonen wrote:
> In function drms_uA_update() in file drivers/regulator/core.c there is a tailing semicolon
> in the end of if() condition which causes the function in question to return unconditionally.
> Remove it to enable rest of the code in the function.
>
> Signed-off-By: Mika Kukkonen <mika.kukkonen@nokia.com>
>
Thanks. Applied a patch for this recently, will be issuing pull request
tonight.
Liam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-28 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-28 7:17 [PATCH] Remove extra semicolon from if() in drivers/regulator/core.c Mika Kukkonen
2009-04-28 13:51 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox