From: Christoph Hellwig <hch@infradead.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
hch@infradead.org, alan@lxorguk.ukuu.org.uk,
sfr@canb.auug.org.au, john@johnmccutchan.com, rlove@rlove.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 12/12] inotify: reimplement inotify using fsnotify
Date: Tue, 28 Apr 2009 05:59:16 -0400 [thread overview]
Message-ID: <20090428095916.GA14452@infradead.org> (raw)
In-Reply-To: <20090427215406.14161.88864.stgit@paris.rdu.redhat.com>
Btw, one thing I noticed is that this adds tons of code despite making
dnotify and inotify use command infrastructure. Do you already add
features not actually used by inotify and dnotify?
Anyway, real review will follow once I get a little time..
next prev parent reply other threads:[~2009-04-28 9:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 21:53 [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock Eric Paris
2009-04-27 21:53 ` [PATCH 02/12] fsnotify: unified filesystem notification backend Eric Paris
2009-04-27 21:53 ` [PATCH 03/12] fsnotify: add marks to inodes so groups can interpret how to handle those inodes Eric Paris
2009-04-27 21:53 ` [PATCH 04/12] fsnotify: parent event notification Eric Paris
2009-04-27 21:53 ` [PATCH 05/12] dnotify: reimplement dnotify using fsnotify Eric Paris
2009-04-28 5:16 ` Stephen Rothwell
2009-04-27 21:53 ` [PATCH 06/12] fsnotify: generic notification queue and waitq Eric Paris
2009-04-27 21:53 ` [PATCH 07/12] fsnotify: include pathnames with entries when possible Eric Paris
2009-04-27 21:53 ` [PATCH 08/12] fsnotify: add correlations between events Eric Paris
2009-04-27 21:53 ` [PATCH 09/12] fsnotify: allow groups to add private data to events Eric Paris
2009-04-27 21:53 ` [PATCH 10/12] fsnotify: fsnotify marks on inodes pin them in core Eric Paris
2009-04-27 21:54 ` [PATCH 11/12] fsnotify: handle filesystem unmounts with fsnotify marks Eric Paris
2009-04-27 21:54 ` [PATCH 12/12] inotify: reimplement inotify using fsnotify Eric Paris
2009-04-28 9:59 ` Christoph Hellwig [this message]
2009-04-28 14:28 ` Eric Paris
2009-04-28 20:27 ` [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock Andrew Morton
2009-04-28 22:46 ` Eric Paris
2009-04-29 11:59 ` Ingo Molnar
2009-04-29 14:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428095916.GA14452@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eparis@redhat.com \
--cc=john@johnmccutchan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@rlove.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox