From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758132AbZD1J6m (ORCPT ); Tue, 28 Apr 2009 05:58:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755969AbZD1J6S (ORCPT ); Tue, 28 Apr 2009 05:58:18 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:36102 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753137AbZD1J6R (ORCPT ); Tue, 28 Apr 2009 05:58:17 -0400 Date: Tue, 28 Apr 2009 12:00:23 +0200 From: Sam Ravnborg To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, hpa@c2micro.com, tglx@linutronix.de, hpa@linux.intel.com, jeremy.fitzhardinge@citrix.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86: linker script: avoid ALIGN statements inside output sections Message-ID: <20090428100023.GA18148@uranus.ravnborg.org> References: <20090428081455.GA19736@elte.hu> <20090428083804.GB17622@uranus.ravnborg.org> <20090428090211.GD26487@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090428090211.GD26487@elte.hu> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Below is hpa's fix merged up by me on top of your cleanups. That > merge-up is incomplete as we lose these fixlets. > > And in this form it's visible how we lose those cleanups you did - > which werent really cleanups ... Please keep such side-effects apart > from truly mechanic cleanups, whenever possible - it makes life > really simpler. The cleanup that you applied did NOT move any ALIGN() - or at least not on purpose. It was supposed to be a noop from a functionality point of view. I have started to unify the the two vmlinux.lds files for 32 and 64 bit - and as part of that serie (yet to be published) you will see individual commits where ALING() is moved and secitons are reordered etc. I do this in baby steps so we can track regressions using bisect. The work is done on top of x86/kbuild and I will rebase as needed when I have it ready. Sam