Re: [PATCH 0/7] KVM support for 1GB pages v2

[Joerg Roedel <joerg.roedel@amd.com>]

On Tue, Apr 28, 2009 at 01:16:07PM +0300, Avi Kivity wrote:
> Joerg Roedel wrote:
>> Hi,
>>
>> this is the second version of the patches implementing support for 1GB
>> pages in KVM. There are too many changes to the first version to mention
>> them all here. The core support was rewritten to work with mapping
>> levels instead of page sizes. This was the main part of the change.
>> The patches still only support KVM with nested paging enabled
>
> What is missing to get shadow paging working with this?  I don't think  
> it's particularly important (it will be pretty hard to find a GB page  
> without any shadowed pages in it), but I don't like arbitrary 
> constraints.

1GB pages with shadow paging does not work yet. But I will post the
patch for it when it works stable for me. It makes sense at least if the
guest uses 1gb pages in hugetlbfs.

> walk_addr() needs to change to support GB pages, did I miss it in the  
> patchset?

Ah true. I missed that in this patchset. I will add it.

Joerg

-- 
           | Advanced Micro Devices GmbH
 Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
 System    | 
 Research  | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
 Center    | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
           | Registergericht München, HRB Nr. 43632