From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
hch@infradead.org, alan@lxorguk.ukuu.org.uk,
sfr@canb.auug.org.au, john@johnmccutchan.com, rlove@rlove.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock
Date: Tue, 28 Apr 2009 13:27:42 -0700 [thread overview]
Message-ID: <20090428132742.7da75691.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090427215305.14161.33354.stgit@paris.rdu.redhat.com>
On Mon, 27 Apr 2009 17:53:05 -0400
Eric Paris <eparis@redhat.com> wrote:
> Much like the atomic_dec_and_lock() function in which we take and hold a
> spin_lock if we drop the atomic to 0 this function takes and holds the
> mutex if we dec the atomic to 0.
I sucked these patches into -mm, mainly for a bit of compile-time and
runtime testing.
I read through them all on the previous iteration. IIRC my main
impression was that the code and the data structures were not
sufficiently well commented for that review to have been particularly
effective. Hopefully things improved there?
It would be good if Al and/or hch and/or others could review this work.
Christoph has indicated that he will be doing this.
You didn't reply to all my review comments from last time, but from a
quick random sample I see that some/most comments have been addressed.
Hopefully all were at least considered.
It's a little worrisome that my comment against this particular patch
was lost, and the patch was verbatim merged into Ingo's perfcounter
branch. Did anything else get lost?
next prev parent reply other threads:[~2009-04-28 20:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 21:53 [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock Eric Paris
2009-04-27 21:53 ` [PATCH 02/12] fsnotify: unified filesystem notification backend Eric Paris
2009-04-27 21:53 ` [PATCH 03/12] fsnotify: add marks to inodes so groups can interpret how to handle those inodes Eric Paris
2009-04-27 21:53 ` [PATCH 04/12] fsnotify: parent event notification Eric Paris
2009-04-27 21:53 ` [PATCH 05/12] dnotify: reimplement dnotify using fsnotify Eric Paris
2009-04-28 5:16 ` Stephen Rothwell
2009-04-27 21:53 ` [PATCH 06/12] fsnotify: generic notification queue and waitq Eric Paris
2009-04-27 21:53 ` [PATCH 07/12] fsnotify: include pathnames with entries when possible Eric Paris
2009-04-27 21:53 ` [PATCH 08/12] fsnotify: add correlations between events Eric Paris
2009-04-27 21:53 ` [PATCH 09/12] fsnotify: allow groups to add private data to events Eric Paris
2009-04-27 21:53 ` [PATCH 10/12] fsnotify: fsnotify marks on inodes pin them in core Eric Paris
2009-04-27 21:54 ` [PATCH 11/12] fsnotify: handle filesystem unmounts with fsnotify marks Eric Paris
2009-04-27 21:54 ` [PATCH 12/12] inotify: reimplement inotify using fsnotify Eric Paris
2009-04-28 9:59 ` Christoph Hellwig
2009-04-28 14:28 ` Eric Paris
2009-04-28 20:27 ` Andrew Morton [this message]
2009-04-28 22:46 ` [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock Eric Paris
2009-04-29 11:59 ` Ingo Molnar
2009-04-29 14:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428132742.7da75691.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=john@johnmccutchan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rlove@rlove.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox