From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Evgeniy Polyakov <zbr@ioremap.net>, Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
Szabolcs Gyurko <szabolcs.gyurko@tlt.hu>,
Matt Reimer <mreimer@vpop.net>, Anton Vorontsov <cbou@mail.ru>
Subject: Re: [PATCH 2/3] w1: ds2760: add support for EEPROM read and write
Date: Tue, 28 Apr 2009 19:01:09 +0400 [thread overview]
Message-ID: <20090428150109.GA14209@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1240908902-24646-2-git-send-email-daniel@caiaq.de>
On Tue, Apr 28, 2009 at 10:55:01AM +0200, Daniel Mack wrote:
> In order to modify the DS2762's status registers and to add support for
> sleep mode, there is need for functions to write the internal EEPROM.
>
> Cc: Szabolcs Gyurko <szabolcs.gyurko@tlt.hu>
> Cc: Matt Reimer <mreimer@vpop.net>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> ---
Evgeniy, don't mind if I take it via battery-2.6.git tree?
> drivers/w1/slaves/w1_ds2760.c | 28 ++++++++++++++++++++++++++++
> drivers/w1/slaves/w1_ds2760.h | 2 ++
> 2 files changed, 30 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/w1/slaves/w1_ds2760.c b/drivers/w1/slaves/w1_ds2760.c
> index 1f09d4e..5ad7a0b 100644
> --- a/drivers/w1/slaves/w1_ds2760.c
> +++ b/drivers/w1/slaves/w1_ds2760.c
> @@ -68,6 +68,34 @@ int w1_ds2760_write(struct device *dev, char *buf, int addr, size_t count)
> return w1_ds2760_io(dev, buf, addr, count, 1);
> }
>
> +static int w1_ds2760_eeprom_cmd(struct device *dev, int addr, int cmd)
> +{
> + struct w1_slave *sl = container_of(dev, struct w1_slave, dev);
> +
> + if (!dev)
> + return -EINVAL;
> +
> + mutex_lock(&sl->master->mutex);
> +
> + if (w1_reset_select_slave(sl) == 0) {
> + w1_write_8(sl->master, cmd);
> + w1_write_8(sl->master, addr);
> + }
> +
> + mutex_unlock(&sl->master->mutex);
> + return 0;
> +}
> +
> +int w1_ds2760_store_eeprom(struct device *dev, int addr)
> +{
> + return w1_ds2760_eeprom_cmd(dev, addr, W1_DS2760_COPY_DATA);
> +}
> +
> +int w1_ds2760_recall_eeprom(struct device *dev, int addr)
> +{
> + return w1_ds2760_eeprom_cmd(dev, addr, W1_DS2760_RECALL_DATA);
> +}
> +
> static ssize_t w1_ds2760_read_bin(struct kobject *kobj,
> struct bin_attribute *bin_attr,
> char *buf, loff_t off, size_t count)
> diff --git a/drivers/w1/slaves/w1_ds2760.h b/drivers/w1/slaves/w1_ds2760.h
> index f130242..ea39419 100644
> --- a/drivers/w1/slaves/w1_ds2760.h
> +++ b/drivers/w1/slaves/w1_ds2760.h
> @@ -46,5 +46,7 @@ extern int w1_ds2760_read(struct device *dev, char *buf, int addr,
> size_t count);
> extern int w1_ds2760_write(struct device *dev, char *buf, int addr,
> size_t count);
> +extern int w1_ds2760_store_eeprom(struct device *dev, int addr);
> +extern int w1_ds2760_recall_eeprom(struct device *dev, int addr);
>
> #endif /* !__w1_ds2760_h__ */
> --
> 1.6.2.1
>
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-04-28 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 8:55 [PATCH 1/3] w1: ds2760_battery: cleanups in ds2760_battery_probe() Daniel Mack
2009-04-28 8:55 ` [PATCH 2/3] w1: ds2760: add support for EEPROM read and write Daniel Mack
2009-04-28 8:55 ` [PATCH 3/3] w1: ds2760_battery: add support for sleep mode feature Daniel Mack
2009-04-28 15:03 ` Anton Vorontsov
2009-04-28 17:11 ` Matt Reimer
2009-04-28 10:22 ` [PATCH 2/3] w1: ds2760: add support for EEPROM read and write Daniel Mack
2009-04-28 15:01 ` Anton Vorontsov [this message]
2009-04-28 16:33 ` Evgeniy Polyakov
2009-04-28 17:11 ` Matt Reimer
2009-04-28 17:10 ` [PATCH 1/3] w1: ds2760_battery: cleanups in ds2760_battery_probe() Matt Reimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428150109.GA14209@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=cbou@mail.ru \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=szabolcs.gyurko@tlt.hu \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox