From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Evgeniy Polyakov <zbr@ioremap.net>, Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
Szabolcs Gyurko <szabolcs.gyurko@tlt.hu>,
Matt Reimer <mreimer@vpop.net>, Anton Vorontsov <cbou@mail.ru>
Subject: Re: [PATCH 3/3] w1: ds2760_battery: add support for sleep mode feature
Date: Tue, 28 Apr 2009 19:03:52 +0400 [thread overview]
Message-ID: <20090428150352.GB14209@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1240908902-24646-3-git-send-email-daniel@caiaq.de>
On Tue, Apr 28, 2009 at 10:55:02AM +0200, Daniel Mack wrote:
> This adds support for ds2760's sleep mode feature. With this feature
> enabled, the chip enters a deep sleep mode and disconnects from the
> battery when the w1 line is held down for more than 2 seconds.
>
> This new behaviour can be switched on and off using a new module
> parameter.
>
> Cc: Szabolcs Gyurko <szabolcs.gyurko@tlt.hu>
> Cc: Matt Reimer <mreimer@vpop.net>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> ---
[...]
> --- a/drivers/power/ds2760_battery.c
> +++ b/drivers/power/ds2760_battery.c
[...]
> diff --git a/drivers/w1/slaves/w1_ds2760.h b/drivers/w1/slaves/w1_ds2760.h
> index ea39419..58e7741 100644
> --- a/drivers/w1/slaves/w1_ds2760.h
> +++ b/drivers/w1/slaves/w1_ds2760.h
> @@ -25,6 +25,10 @@
>
> #define DS2760_PROTECTION_REG 0x00
> #define DS2760_STATUS_REG 0x01
> + #define DS2760_STATUS_IE (1 << 2)
> + #define DS2760_STATUS_SWEN (1 << 3)
> + #define DS2760_STATUS_RNAOP (1 << 4)
> + #define DS2760_STATUS_PMOD (1 << 5)
The single patch touch battery and w1 trees.
So, Evgeniy, would you mind if I take this patch?
Thanks!
> #define DS2760_EEPROM_REG 0x07
> #define DS2760_SPECIAL_FEATURE_REG 0x08
> #define DS2760_VOLTAGE_MSB 0x0c
> @@ -38,6 +42,7 @@
> #define DS2760_EEPROM_BLOCK0 0x20
> #define DS2760_ACTIVE_FULL 0x20
> #define DS2760_EEPROM_BLOCK1 0x30
> +#define DS2760_STATUS_WRITE_REG 0x31
> #define DS2760_RATED_CAPACITY 0x32
> #define DS2760_CURRENT_OFFSET_BIAS 0x33
> #define DS2760_ACTIVE_EMPTY 0x3b
> --
> 1.6.2.1
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-04-28 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 8:55 [PATCH 1/3] w1: ds2760_battery: cleanups in ds2760_battery_probe() Daniel Mack
2009-04-28 8:55 ` [PATCH 2/3] w1: ds2760: add support for EEPROM read and write Daniel Mack
2009-04-28 8:55 ` [PATCH 3/3] w1: ds2760_battery: add support for sleep mode feature Daniel Mack
2009-04-28 15:03 ` Anton Vorontsov [this message]
2009-04-28 17:11 ` Matt Reimer
2009-04-28 10:22 ` [PATCH 2/3] w1: ds2760: add support for EEPROM read and write Daniel Mack
2009-04-28 15:01 ` Anton Vorontsov
2009-04-28 16:33 ` Evgeniy Polyakov
2009-04-28 17:11 ` Matt Reimer
2009-04-28 17:10 ` [PATCH 1/3] w1: ds2760_battery: cleanups in ds2760_battery_probe() Matt Reimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428150352.GB14209@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=cbou@mail.ru \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=szabolcs.gyurko@tlt.hu \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox