From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c
Date: Wed, 29 Apr 2009 00:36:19 +0200 [thread overview]
Message-ID: <20090428223619.GA12027@redhat.com> (raw)
In-Reply-To: <20090428223050.GA12020@redhat.com>
On 04/29, Oleg Nesterov wrote:
>
> - prstatus->pr_ppid = task_pid_vnr(p->parent);
> + prstatus->pr_ppid = task_pid_vnr(p->real_parent);
> prstatus->pr_pgrp = task_pgrp_vnr(p);
Hmm. Just noticed. What protects ->parent or ->real_parent ?
Looks like we need rcu_lock() around... The same in fs/binfmt_elf.c.
Will send another trivial patch (on top of this) tomorrow.
Oleg.
next prev parent reply other threads:[~2009-04-28 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 22:30 [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c Oleg Nesterov
2009-04-28 22:36 ` Oleg Nesterov [this message]
2009-04-29 9:46 ` David Howells
2009-04-29 18:12 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428223619.GA12027@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox