From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 5/5] ring-buffer: fix printk output
Date: Tue, 28 Apr 2009 22:55:41 -0700 [thread overview]
Message-ID: <20090428225541.9ca61a12.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090429054359.GA6148@elte.hu>
On Wed, 29 Apr 2009 07:43:59 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Wed, 29 Apr 2009 00:48:19 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > - printk_once(KERN_WARNING "Tracing recursion: depth[%d]:"
> > > + printk_once(KERN_WARNING "Tracing recursion: depth[%ld]:"
> >
> > hrmph. I didn't know that printk_once() existed, and I should
> > have known. I wonder how many other people don't know.
>
> Was posted to linux-next@vger.kernel.org.
Well no wonder I didn't know about it.
> > Should it use unlikely()?
>
> Not really. Any printk_once() usage site is an 'unlikely' branch
> already in most cases. Double unlikely just spreads the instructions
> needlessly. The condition that _leads_ to a printk_once() should be
> an unlikely().
>
OK.
next prev parent reply other threads:[~2009-04-29 5:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 4:48 [PATCH 0/5] [GIT PULL] tracing/splice/ringbuffer: updates for tip Steven Rostedt
2009-04-29 4:48 ` [PATCH 1/5] tracing: convert ftrace_dump spinlocks to raw Steven Rostedt
2009-04-29 5:07 ` Andrew Morton
2009-04-29 5:55 ` Ingo Molnar
2009-04-29 4:48 ` [PATCH 2/5] tracing: fix ref count in splice pages Steven Rostedt
2009-04-29 4:48 ` [PATCH 3/5] tracing: only add splice page if entries exist Steven Rostedt
2009-04-29 4:48 ` [PATCH 4/5] tracing: have splice only copy full pages Steven Rostedt
2009-04-29 4:48 ` [PATCH 5/5] ring-buffer: fix printk output Steven Rostedt
2009-04-29 5:20 ` Andrew Morton
2009-04-29 5:43 ` Ingo Molnar
2009-04-29 5:55 ` Andrew Morton [this message]
2009-04-29 6:09 ` Ingo Molnar
2009-04-29 6:20 ` Andrew Morton
2009-04-29 7:22 ` Ingo Molnar
2009-04-29 7:41 ` Andrew Morton
2009-04-29 9:56 ` Ingo Molnar
2009-04-29 15:09 ` Andrew Morton
2009-04-29 19:45 ` Ingo Molnar
2009-04-29 19:52 ` Andrew Morton
2009-04-29 20:11 ` Ingo Molnar
2009-04-29 16:19 ` Valdis.Kletnieks
2009-04-29 20:15 ` Ingo Molnar
2009-04-29 6:03 ` [PATCH 0/5] [GIT PULL] tracing/splice/ringbuffer: updates for tip Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428225541.9ca61a12.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox