Re: [PATCH] poll: Avoid extra wakeups in select/poll

Ingo Molnar
2009-04-29T09:24:20Z

* Andi Kleen <andi@firstfloor.org> wrote:

> > Seems that this is a virtuous patch even though Christoph is struggling
> > a bit to test it?
>
> The main drawback is that the select/poll data structures will get
> larger. That could cause regression in theory. [...]

Current size of struct poll_table_entry is 0x38 on 64-bit kernels.
Adding the key will make it 0x40 - which is not only a power of two
but also matches cache line size on most modern CPUs.

So the size of this structure is ideal now and arithmetics on the
poll table have become simpler as well.

So the patch has my ack:

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo