public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 0/5] [GIT PULL] tracing/splice/ringbuffer: updates for tip
Date: Wed, 29 Apr 2009 00:48:14 -0400	[thread overview]
Message-ID: <20090429044814.138790038@goodmis.org> (raw)


Ingo,

I was doing a bit of tracing that was stressing the splice code
and I found lots of badness. Mostly, the second patch is the killer,
and should most likely go upstream ASAP. The ref counting on the
splice page is wrong and is never freed!

The rest are fixes to the read side. While debugging the memory leak
I pulled out my old logdev and used it to monitor what was happening
inside of ftrace (tracing the tracer). I did not like the amount
of copying that was happening in splice. This was mainly because
splice was faster than the writer (and this was with function tracer
running!). I added some enhancements to make the splice code
perform a little nicer.

Here's the logdev patch I was using to trace. As well as adding
my lfcnprint statements (similar to trace_printk).

  http://rostedt.homelinux.com/logdev/logdev-0.6.0-2.6.30-rc1.patch

Please pull the latest tip/tracing/ftrace-1 tree, which can be found at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/tracing/ftrace-1


Steven Rostedt (5):
      tracing: convert ftrace_dump spinlocks to raw
      tracing: fix ref count in splice pages
      tracing: only add splice page if entries exist
      tracing: have splice only copy full pages
      ring-buffer: fix printk output

----
 kernel/trace/ring_buffer.c |    2 +-
 kernel/trace/trace.c       |   20 ++++++++++++++------
 2 files changed, 15 insertions(+), 7 deletions(-)
-- 

             reply	other threads:[~2009-04-29  4:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29  4:48 Steven Rostedt [this message]
2009-04-29  4:48 ` [PATCH 1/5] tracing: convert ftrace_dump spinlocks to raw Steven Rostedt
2009-04-29  5:07   ` Andrew Morton
2009-04-29  5:55     ` Ingo Molnar
2009-04-29  4:48 ` [PATCH 2/5] tracing: fix ref count in splice pages Steven Rostedt
2009-04-29  4:48 ` [PATCH 3/5] tracing: only add splice page if entries exist Steven Rostedt
2009-04-29  4:48 ` [PATCH 4/5] tracing: have splice only copy full pages Steven Rostedt
2009-04-29  4:48 ` [PATCH 5/5] ring-buffer: fix printk output Steven Rostedt
2009-04-29  5:20   ` Andrew Morton
2009-04-29  5:43     ` Ingo Molnar
2009-04-29  5:55       ` Andrew Morton
2009-04-29  6:09         ` Ingo Molnar
2009-04-29  6:20           ` Andrew Morton
2009-04-29  7:22             ` Ingo Molnar
2009-04-29  7:41               ` Andrew Morton
2009-04-29  9:56                 ` Ingo Molnar
2009-04-29 15:09                   ` Andrew Morton
2009-04-29 19:45                     ` Ingo Molnar
2009-04-29 19:52                       ` Andrew Morton
2009-04-29 20:11                         ` Ingo Molnar
2009-04-29 16:19             ` Valdis.Kletnieks
2009-04-29 20:15               ` Ingo Molnar
2009-04-29  6:03 ` [PATCH 0/5] [GIT PULL] tracing/splice/ringbuffer: updates for tip Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090429044814.138790038@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox