public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] crypto: catch base cipher self-test failures in fips mode
Date: Wed, 29 Apr 2009 08:38:45 -0400	[thread overview]
Message-ID: <200904290838.45896.jarod@redhat.com> (raw)
In-Reply-To: <20090429103623.GB7227@hmsreliant.think-freely.org>

On Wednesday 29 April 2009 06:36:23 Neil Horman wrote:
> On Tue, Apr 28, 2009 at 09:11:51PM -0400, Jarod Wilson wrote:
> > I think this might have already been posted by Neil Horman, and
> > we already have it in the Red Hat Enterprise Linux 5.x kernels,
> > but in fips mode, we need to panic on the base cipher self-tests
> > failing as well as the later tests.
> > 
> > Signed-off-by: Jarod Wilson <jarod@redhat.com>
> > 
> I did post it:
> http://www.mail-archive.com/linux-crypto@vger.kernel.org/msg02307.html
> looks like it somehow just never made it to Linus.  Thanks for noticing, Jarod.

That part got committed, this is an additional piece, as I believe that
wasn't quite complete. This patch adds another check for the rc of
alg_test_cipher() (vs. only the check for alg_test_descs[i].test()).

-- 
Jarod Wilson
jarod@redhat.com

  reply	other threads:[~2009-04-29 12:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29  1:11 [PATCH] crypto: catch base cipher self-test failures in fips mode Jarod Wilson
2009-04-29 10:36 ` Neil Horman
2009-04-29 12:38   ` Jarod Wilson [this message]
2009-04-29 13:15 ` Herbert Xu
2009-04-29 13:18   ` Jarod Wilson
2009-04-29 13:26     ` Herbert Xu
2009-04-29 13:34       ` Jarod Wilson
2009-04-30 20:21         ` [PATCH v2] " Jarod Wilson
2009-05-04 11:49           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904290838.45896.jarod@redhat.com \
    --to=jarod@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox