From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758670AbZD2Nfs (ORCPT ); Wed, 29 Apr 2009 09:35:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757787AbZD2NfV (ORCPT ); Wed, 29 Apr 2009 09:35:21 -0400 Received: from mx2.redhat.com ([66.187.237.31]:40135 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756744AbZD2NfT (ORCPT ); Wed, 29 Apr 2009 09:35:19 -0400 From: Jarod Wilson Organization: Red Hat, Inc. To: Herbert Xu Subject: Re: [PATCH] crypto: catch base cipher self-test failures in fips mode Date: Wed, 29 Apr 2009 09:34:31 -0400 User-Agent: KMail/1.11.2 (Linux/2.6.29.1-102.fc11.x86_64; KDE/4.2.2; x86_64; ; ) Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Horman References: <200904282111.52074.jarod@redhat.com> <200904290918.37623.jarod@redhat.com> <20090429132646.GA17481@gondor.apana.org.au> In-Reply-To: <20090429132646.GA17481@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904290934.32404.jarod@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 29 April 2009 09:26:46 Herbert Xu wrote: > On Wed, Apr 29, 2009 at 09:18:37AM -0400, Jarod Wilson wrote: > > On Wednesday 29 April 2009 09:15:07 Herbert Xu wrote: > > > On Tue, Apr 28, 2009 at 09:11:51PM -0400, Jarod Wilson wrote: > > > > > > > > +notest: > > > > + printk(KERN_INFO "alg: No test for %s (%s)\n", alg, driver); > > > > > > Can notest ever get here with rc != 0? > > > > Nope. > > So why do we need to move it? Oh. Hrm. Upon looking a bit harder at it, I think the only reason would be if we wanted to print out a message claiming success in testing ctr(aes). There's also a devious ulterior motive for this patch, which is to make the cryptodev tree look identical(er) to the Red Hat Enterprise Linux 5.x kernel tree w/in alg_test()... -- Jarod Wilson jarod@redhat.com