From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
fweisbec@gmail.com, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH 2/3] tracing/filters: distinguish between signed and unsigned fields
Date: Wed, 29 Apr 2009 12:36:55 +0200 [thread overview]
Message-ID: <20090429103655.GD2373@elte.hu> (raw)
In-Reply-To: <20090428234645.c1780736.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 28 Apr 2009 03:04:53 -0500 Tom Zanussi <tzanussi@gmail.com> wrote:
>
> > +#define is_signed(t) (((t)-1) < 0)
>
> geeze that was confusing until I worked out that `t' is supposed to be
> the name of a C type.
good point, i've changed its name to is_signed_type().
> is_signed(0) == true!
>
> whee.
I also added parantheses around the -1 literal to make it clear that
this is a cast.
> Rename it to is_signed_type() or something, please?
done.
Thanks,
Ingo
next prev parent reply other threads:[~2009-04-29 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 8:04 [PATCH 2/3] tracing/filters: distinguish between signed and unsigned fields Tom Zanussi
2009-04-29 6:46 ` Andrew Morton
2009-04-29 10:36 ` Ingo Molnar [this message]
2009-04-29 12:06 ` [tip:tracing/core] " tip-bot for Tom Zanussi
2009-04-29 12:09 ` tip-bot for Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429103655.GD2373@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox