Re: [PATCH] Fix dirty page accounting in redirty_page_for_writepage()

Mathieu Desnoyers
2009-04-30T02:43:20Z

* Linus Torvalds (torvalds@linux-foundation.org) wrote:
>
>
> On Wed, 29 Apr 2009, Mathieu Desnoyers wrote:
> >
> > This patch adds missing dirty page accounting in redirty_page_for_writepage().
> > This should fix a _lot_ of issues involving machines becoming slow under heavy
> > write I/O. No surprise : eventually the system starts swapping.
>
> That patch (and description) is odd.
>
> The patch actually adds the dirty page accounting not to
> redirty_page_for_writepage(), but to __set_page_dirty_nobuffers().
>
> And __set_page_dirty_nobuffers() will later (just a few lines down) call
> down to account_page_dirtied(), which in turn does all that
> same accounting (assuming the "mapping" is marked to account for dirty.
>
> So the description seems to be wrong, but so does the patch.
>
> Did you attach the wrong patch (explaining both problems)?
>

Nope, just tried to go back into the OOM problem I experienced when
testing the "heavy I/O latency" bug. But it looks like I can't reproduce
it anyway.

> Or if the patch is what you really meant to do, then you need to fix your
> explanation, and also explain why the double-dirty accounting is a good
> idea.

Nope, I just "messed this one up" completely. :-)

>
> Or is the real problem perhaps that your /tmp is ramdisk, and not marked
> to do dirty accounting?

Nope, I don't think so. /tmp is on a ext3 partition, on raid 1, sata
disks.

And thanks for the review! This excercise only convinced me that the
kernel memory accounting works as expected. All this gave me the chance
to have a good look at the memory accounting code. We could probably
benefit of Christoph Lameter's cpu ops (using segment registers to
address per-cpu variables with atomic inc/dec) in there. Or at least
removing interrupt disabling by using preempt disable and local_t
variables for the per-cpu counters could bring some benefit.

Mathieu

>
> Linus

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68