From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Robert Richter <robert.richter@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf_counter: powerpc: allow use of limited-function counters
Date: Thu, 30 Apr 2009 08:58:56 +0200 [thread overview]
Message-ID: <20090430065856.GA16737@elte.hu> (raw)
In-Reply-To: <18936.56613.479043.380867@cargo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> Ingo Molnar wrote:
>
> > [ Note, i saw some fuzz in those files. It applied fine but maybe
> > you have some local changes in them that are not in
> > tip:perfcounters/core yet? You might want to double check that. ]
>
> I think it was just Robert Richter's changes that caused the fuzz.
> The end result seems to be OK.
ah, indeed - the rename:
4aeb0b4: perfcounters: rename struct hw_perf_counter_ops into struct pmu
changed context lines in your patch causing the fuzz. The mechanic
rename changed quite a bit of stuff in the powerpc driver - we were
lucky that your rather large patch still merged cleanly.
Btw, if in the future such renames cause problems for any pending
patch of yours we can always pick up your patches first and then
re-do the rename.
Ingo
prev parent reply other threads:[~2009-04-30 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 12:38 [PATCH] perf_counter: powerpc: allow use of limited-function counters Paul Mackerras
2009-04-29 13:09 ` [tip:perfcounters/core] " tip-bot for Paul Mackerras
2009-04-29 13:09 ` [PATCH] " Ingo Molnar
2009-04-29 23:05 ` Paul Mackerras
2009-04-30 6:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430065856.GA16737@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox