Re: [PATCH] Intel IOMMU Pass Through Support

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 30 Apr 2009 17:05:10 -0700
Fenghua Yu <fenghua.yu@intel.com> wrote:

> > > : --- a/arch/x86/kernel/pci-dma.c
> > > : +++ b/arch/x86/kernel/pci-dma.c
> > > : @@ -160,6 +160,8 @@ again:
> > > :         return page_address(page);
> > > :  }
> > > :  
> > > : +extern int iommu_pass_through;
> > > : +
> > > 
> > > Which is wrong and unnecessary - the variable was already declared in a
> > > header file.
> > > 
> > > scripts/checkpatch.pl would have warned you about this error, but
> > > apparently neither you nor the people who reviewed or merged the patch
> > > bother to use it.
> 
> Actually checkpatch.pl doesn't report anything wrong with this statement.

Running 4ed0d3e6c64cfd9ba4ceb2099b10d1cf8ece4320 through checkpatch produces
the below output:

WARNING: externs should be avoided in .c files
#83: FILE: arch/x86/kernel/pci-dma.c:163:
+extern int iommu_pass_through;

WARNING: suspect code indent for conditional statements (8, 15)
#108: FILE: arch/x86/kernel/pci-swiotlb.c:74:
+       if ((!iommu_detected && !no_iommu && max_pfn > MAX_DMA32_PFN) ||
[...]
               swiotlb = 1;