From: Jean Delvare <khali@linux-fr.org>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] asus_atk0110: fix compiler warning
Date: Thu, 30 Apr 2009 19:01:01 +0200 [thread overview]
Message-ID: <20090430190101.7a46f082@hyperion.delvare> (raw)
In-Reply-To: <20090429192255.GA8623@dreamland.darkstar.lan>
Hi Luca,
On Wed, 29 Apr 2009 21:22:55 +0200, Luca Tettamanti wrote:
> atk_sensor_type is only used when DEBUG is defined.
>
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
>
> ---
> Jean can you pick this up?
>
> drivers/hwmon/asus_atk0110.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index 0897ede..bff0103 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -348,6 +348,7 @@ static int validate_hwmon_pack(struct atk_data *data, union acpi_object *obj)
> return 0;
> }
>
> +#ifdef DEBUG
> static char const *atk_sensor_type(union acpi_object *flags)
> {
> u64 type = flags->integer.value & ATK_TYPE_MASK;
> @@ -370,6 +371,7 @@ static char const *atk_sensor_type(union acpi_object *flags)
>
> return what;
> }
> +#endif
>
> static void atk_print_sensor(struct atk_data *data, union acpi_object *obj)
> {
Thanks for the fix, I've just applied it.
--
Jean Delvare
prev parent reply other threads:[~2009-04-30 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 19:22 [PATCH] asus_atk0110: fix compiler warning Luca Tettamanti
2009-04-30 17:01 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430190101.7a46f082@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox