From: Jack Steiner <steiner@sgi.com>
To: akpm@linux-foundation.org, piggin@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] - Fix memory corruption in slbq
Date: Thu, 30 Apr 2009 19:41:06 -0500 [thread overview]
Message-ID: <20090501004105.GA16409@sgi.com> (raw)
Fix memory corruption caused by slqb overrunning the end
of the page allocated in kmem_cache_dyn_array_alloc() for
initial caches.
Signed-off-by: Jack Steiner <steiner@sgi.com>
---
mm/slqb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux/mm/slqb.c
===================================================================
--- linux.orig/mm/slqb.c 2009-04-30 15:47:16.000000000 -0500
+++ linux/mm/slqb.c 2009-04-30 19:08:33.000000000 -0500
@@ -2194,15 +2194,14 @@ static void *kmem_cache_dyn_array_alloc(
* never get freed by definition so we can do it rather
* simply.
*/
- if (!nextmem) {
+ if (!nextmem || offset_in_page(nextmem) + size > PAGE_SIZE) {
nextmem = alloc_pages_exact(size, GFP_KERNEL);
if (!nextmem)
return NULL;
}
ret = nextmem;
nextmem = (void *)((unsigned long)ret + size);
- if ((unsigned long)ret >> PAGE_SHIFT !=
- (unsigned long)nextmem >> PAGE_SHIFT)
+ if (offset_in_page(ret) + size >= PAGE_SIZE)
nextmem = NULL;
memset(ret, 0, size);
return ret;
next reply other threads:[~2009-05-01 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 0:41 Jack Steiner [this message]
2009-05-03 12:18 ` [PATCH] - Fix memory corruption in slbq Pekka Enberg
2009-05-03 12:24 ` Jack Steiner
2009-05-03 12:28 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090501004105.GA16409@sgi.com \
--to=steiner@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox