Re: [PATCH 17/27] add generic lib/checksum.c

Michal Simek
2009-05-01T09:23:41Z

Russell King wrote:
> On Tue, Mar 31, 2009 at 03:30:31PM +0200, Arnd Bergmann wrote:
>> +/*
>> + * copy from fs while checksumming, otherwise like csum_partial
>> + */
>> +__wsum
>> +csum_partial_copy_from_user(const void __user *src, void *dst, int len,
>> + __wsum sum, int *csum_err)
>> +{
>> + if (csum_err)
>> + *csum_err = 0;
>> + memcpy(dst, src, len);
>
> Since when has 'memcpy' been valid from user addresses?
>
yes, that's wrong

copy_from_user(dst, src, len);

should be there

Michal

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854