From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762954AbZEAT3A (ORCPT ); Fri, 1 May 2009 15:29:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753657AbZEAT2w (ORCPT ); Fri, 1 May 2009 15:28:52 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48988 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbZEAT2v (ORCPT ); Fri, 1 May 2009 15:28:51 -0400 Date: Fri, 1 May 2009 12:26:25 -0700 From: Andrew Morton To: Kay Sievers Cc: linux-kernel@vger.kernel.org, greg@kroah.com, jblunck@suse.de Subject: Re: [PATCH] driver-core: devtmpfs - driver core maintained /dev tmpfs Message-Id: <20090501122625.a60ccbbe.akpm@linux-foundation.org> In-Reply-To: References: <1241097822.2516.3.camel@poy> <20090430222900.c13b63d5.akpm@linux-foundation.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 May 2009 13:16:22 +0200 Kay Sievers wrote: > On Fri, May 1, 2009 at 07:29, Andrew Morton wrote: > > > dev->type->nodename() might have failed due to -ENOMEM, in which case > > it seems wrong to assume that it returned NULL for > thought it might want to return NULL>. > > > > It's all a bit confused. > > This logic is only for providing a custom name hint. Only a few > devices need that at all. If the allocation fails, the default name > will be used, not the custom name. But that's bad, isn't it? It means that the kernel will come up with one name if the memory allcoation succeeded, and a different name if the allocation failed.