From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Mahoney <jeffm@suse.com>
Cc: linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org,
viro@ftp.linux.org.uk, a.beregalov@gmail.com,
david@unsolicited.net, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] reiserfs: Expand i_mutex to enclose lookup_one_len
Date: Fri, 1 May 2009 12:56:27 -0700 [thread overview]
Message-ID: <20090501125627.e13ff38f.akpm@linux-foundation.org> (raw)
In-Reply-To: <49FB1F20.8040400@suse.com>
On Fri, 01 May 2009 12:11:12 -0400
Jeff Mahoney <jeffm@suse.com> wrote:
> 2.6.30-rc3 introduced some sanity checks in the VFS code to avoid NFS
> bugs by ensuring that lookup_one_len is always called under i_mutex.
>
> This patch expands the i_mutex locking to enclose lookup_one_len. This was
> always required, but not not enforced in the reiserfs code since it
> does locking around the xattr interactions with the xattr_sem.
cool, so this will fix all those backtraces people have been reporting
coming out of the reiserfs xattr code lately?
> This is obvious enough, but it survived an overnight 50 thread ACL test.
That sounds a bit pessimistic. I think I'll s/but/and/ ;)
next prev parent reply other threads:[~2009-05-01 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 16:11 [PATCH] reiserfs: Expand i_mutex to enclose lookup_one_len Jeff Mahoney
2009-05-01 16:37 ` Alexander Beregalov
2009-05-01 19:56 ` Andrew Morton [this message]
2009-05-01 20:36 ` Jeff Mahoney
2009-05-03 8:52 ` Al Viro
2009-05-03 9:15 ` Al Viro
2009-05-03 10:06 ` Al Viro
2009-05-04 4:51 ` Jeff Mahoney
2009-05-04 6:13 ` Al Viro
2009-05-04 16:40 ` Jeff Mahoney
2009-05-05 19:29 ` Jeff Mahoney
2009-05-04 5:01 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090501125627.e13ff38f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.beregalov@gmail.com \
--cc=david@unsolicited.net \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox