From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbZEBCsG (ORCPT ); Fri, 1 May 2009 22:48:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751243AbZEBCrz (ORCPT ); Fri, 1 May 2009 22:47:55 -0400 Received: from mga14.intel.com ([143.182.124.37]:33418 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbZEBCry (ORCPT ); Fri, 1 May 2009 22:47:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.40,281,1239001200"; d="scan'208";a="138349166" Date: Sat, 2 May 2009 10:47:19 +0800 From: Wu Fengguang To: Andrew Morton Cc: "torvalds@linux-foundation.org" , "kosaki.motohiro@jp.fujitsu.com" , "lee.schermerhorn@hp.com" , "peterz@infradead.org" , "riel@redhat.com" , "linux-mm@kvack.org" , LKML , Nick Piggin , Christoph Lameter Subject: [RFC][PATCH] vmscan: don't export nr_saved_scan in /proc/zoneinfo Message-ID: <20090502024719.GA29730@localhost> References: <200904302208.n3UM8t9R016687@imap1.linux-foundation.org> <20090501012212.GA5848@localhost> <20090430194907.82b31565.akpm@linux-foundation.org> <20090502023125.GA29674@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090502023125.GA29674@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The lru->nr_saved_scan's are not meaningful counters for even kernel developers. They typically are smaller than 32 and are always 0 for large lists. So remove them from /proc/zoneinfo. Hopefully this interface change won't break too many scripts. /proc/zoneinfo is too unstructured to be script friendly, and I wonder the affected scripts - if there are any - are still bleeding since the not long ago commit "vmscan: split LRU lists into anon & file sets", which also touched the "scanned" line :) If we are to re-export accumulated vmscan counts in the future, they can go to new lines in /proc/zoneinfo instead of the current form, or to /sys/devices/system/node/node0/meminfo? CC: Christoph Lameter Signed-off-by: Wu Fengguang --- mm/vmstat.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- mm.orig/mm/vmstat.c +++ mm/mm/vmstat.c @@ -721,7 +721,7 @@ static void zoneinfo_show_print(struct s "\n min %lu" "\n low %lu" "\n high %lu" - "\n scanned %lu (aa: %lu ia: %lu af: %lu if: %lu)" + "\n scanned %lu" "\n spanned %lu" "\n present %lu", zone_page_state(zone, NR_FREE_PAGES), @@ -729,10 +729,6 @@ static void zoneinfo_show_print(struct s zone->pages_low, zone->pages_high, zone->pages_scanned, - zone->lru[LRU_ACTIVE_ANON].nr_saved_scan, - zone->lru[LRU_INACTIVE_ANON].nr_saved_scan, - zone->lru[LRU_ACTIVE_FILE].nr_saved_scan, - zone->lru[LRU_INACTIVE_FILE].nr_saved_scan, zone->spanned_pages, zone->present_pages);