The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@lisas.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
	netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	stable@kernel.org
Subject: Re: [PATCH] Do not register ne2k-pci device until initialized
Date: Sat, 2 May 2009 19:58:11 +0200	[thread overview]
Message-ID: <20090502175811.GA26635@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <49FC7D5E.6050203@garzik.org>

Hi,

> Good spotting, that fixes a clear startup race

I saw this and thought that this must be one of those non-singular bugs
again... ;)

(I checked for dev_addr manipulations _after_ register_netdev)

And, well...:

smsc911x.c looks like it has the same issue (in case of a non-specified
MAC address - invalid EEPROM content).

Dito ucc_geth.c

Dito arm/ixp4xx_eth.c

Dito wireless/netwave_cs.c


Given that several drivers seem to violate this rule: is there a way
to add a check against this problem?

Andreas Mohr

  reply	other threads:[~2009-05-02 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-02 16:28 [PATCH] Do not register ne2k-pci device until initialized Lubomir Rintel
2009-05-02 17:05 ` Jeff Garzik
2009-05-02 17:58   ` Andreas Mohr [this message]
2009-05-02 20:52     ` David Miller
2009-05-03 16:34     ` Krzysztof Halasa
2009-05-02 20:52   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090502175811.GA26635@rhlx01.hs-esslingen.de \
    --to=andi@lisas.de \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox