Re: [PATCH] export softirq_to_name symbol

[Ingo Molnar <mingo@elte.hu>]

* Jason Baron <jbaron@redhat.com> wrote:

> hi,
> 
> In response to a user request:
> 
> Export 'softirq_to_name' so that modules using the softirq 
> tracepoints can resolve the # to a name.
> 
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
>  kernel/softirq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index b76064b..1841ab7 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -60,6 +60,7 @@ char *softirq_to_name[NR_SOFTIRQS] = {
>  	"HI", "TIMER", "NET_TX", "NET_RX", "BLOCK",
>  	"TASKLET", "SCHED", "HRTIMER",	"RCU"
>  };
> +EXPORT_SYMBOL_GPL(softirq_to_name);

Hm, that very much looks like as if someone was writing kernel 
tracing code without the intention to submitting it upstream. Not 
having exported that symbol is thus a subtle "dont do that please" 
warning sign ;-)

	Ingo