From: Frederic Weisbecker <fweisbec@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josh Stone <jistone@redhat.com>, Jason Baron <jbaron@redhat.com>,
mingo@elte.hu, rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] export softirq_to_name symbol
Date: Sun, 3 May 2009 20:36:51 +0200 [thread overview]
Message-ID: <20090503183650.GB6010@nowhere> (raw)
In-Reply-To: <20090501201028.GA2084@infradead.org>
On Fri, May 01, 2009 at 04:10:28PM -0400, Christoph Hellwig wrote:
> On Fri, May 01, 2009 at 01:07:34PM -0700, Josh Stone wrote:
> > I'm adding SystemTap support for the format strings in the TRACE_EVENT
> > macros. The softirq's TP_fast_assign uses softirq_to_name, and so that
> > array is needed to prepare the softirq's trace string.
> >
> > So, there's no explicit reference to the symbol in SystemTap -- it's
> > just indirectly referenced by the tracepoint declaration.
>
> TP_fast_assign should only be called by core code, it's the piece that
> copies the trace into the ring buffer. If systemtap copies events into
> the ring buffer from modular code something is deeply wrong in it's
> design.
In itself, the use of TRACE_EVENT from a module is fine, otherwise
Steve wouldn't have written the module support.
For example the mac80211 subsystem can be built as a module, and
if a tracing code is merged for this subsystem, we want it to be
usable whenever it is build as a module or not.
Frederic.
next prev parent reply other threads:[~2009-05-03 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 19:30 [PATCH] export softirq_to_name symbol Jason Baron
2009-05-01 19:50 ` Christoph Hellwig
2009-05-01 20:07 ` Josh Stone
2009-05-01 20:10 ` Christoph Hellwig
2009-05-01 20:17 ` Josh Stone
2009-05-01 20:22 ` Christoph Hellwig
2009-05-01 21:25 ` Josh Stone
2009-05-03 18:36 ` Frederic Weisbecker [this message]
2009-05-03 8:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090503183650.GB6010@nowhere \
--to=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=jistone@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox